flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8816) Remove the oldWorker only after starting newWorker successfully in registerTaskExecutorInternal()
Date Thu, 01 Mar 2018 09:37:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381743#comment-16381743
] 

ASF GitHub Bot commented on FLINK-8816:
---------------------------------------

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/5604
  
    I think this cannot happen since a `TaskExecutor` will only try to reconnect if the previous
connection attempt failed/timed out. So there should not be the chance that you receive two
registration success messages if I'm not mistaken.


> Remove the oldWorker only after starting newWorker successfully in registerTaskExecutorInternal()
> -------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-8816
>                 URL: https://issues.apache.org/jira/browse/FLINK-8816
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0
>            Reporter: Sihua Zhou
>            Assignee: Sihua Zhou
>            Priority: Major
>             Fix For: 1.5.0
>
>
> We should remove the oldWorker only after starting newWorker successfully in {{ResourceManager#registerTaskExecutorInternal}}
and javadoc for {{SlotProvider#allocateSlot}} is outdated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message