flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8821) Fix BigDecimal divide in AvgAggFunction
Date Thu, 01 Mar 2018 10:57:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381828#comment-16381828

ASF GitHub Bot commented on FLINK-8821:

GitHub user Xpray opened a pull request:


    [FLINK-8821][TableAPI && SQL] Fix BigDecimal divide in AvgAggFunction

    ## What is the purpose of the change
    fix BigDecimal divide issue in AvgAggFunction
    ## Brief change log
      - *set MathContext  to DecimalAvgAggFunction*
    ## Verifying this change
    This change is already covered by existing tests, such as *(please describe tests)*.
    ## Does this pull request potentially affect one of the following parts:
      - Dependencies (does it add or upgrade a dependency):
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: 
      - The serializers: 
      - The runtime per-record code paths (performance sensitive): 
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: 
      - The S3 file system connector: 
    ## Documentation
      - Does this pull request introduce a new feature? 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Xpray/flink FLINK-8821

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5608
commit 6de872e7d562354f65accf6eaeb7604f46cf7352
Author: Xpray <leonxpray@...>
Date:   2018-03-01T10:50:13Z

    [FLINK-8821][TableAPI && SQL] Fix BigDecimal divide in AvgAggFunction


> Fix BigDecimal divide in AvgAggFunction
> ---------------------------------------
>                 Key: FLINK-8821
>                 URL: https://issues.apache.org/jira/browse/FLINK-8821
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API &amp; SQL
>            Reporter: Ruidong Li
>            Assignee: Ruidong Li
>            Priority: Major
> The DecimalAvgAggFunction lacks precision protection

This message was sent by Atlassian JIRA

View raw message