flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8822) RotateLogFile may not work well when sed version is below 4.2
Date Thu, 01 Mar 2018 20:58:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382631#comment-16382631
] 

ASF GitHub Bot commented on FLINK-8822:
---------------------------------------

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5609
  
    Not sure about this one, after all `4.2` is already _9 years old_.
    
    According to https://stackoverflow.com/questions/3139126/whats-the-difference-between-sed-e-and-sed-e
and https://www.gnu.org/software/sed/manual/sed.html it also looks like `-E` is more portable.


> RotateLogFile may not work well when sed version is below 4.2
> -------------------------------------------------------------
>
>                 Key: FLINK-8822
>                 URL: https://issues.apache.org/jira/browse/FLINK-8822
>             Project: Flink
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Xin Liu
>            Priority: Major
>             Fix For: 1.5.0
>
>
> In bin/config.sh rotateLogFilesWithPrefix(),it use extended regular to process filename
with "sed -E",but when sed version is below 4.2,it turns out "sed: invalid option -- 'E'"
> and RotateLogFile won't work well : There will be only one logfile no matter what is
$MAX_LOG_FILE_NUMBER.
> so use sed -r may be more suitable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message