flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8843) Decouple bind REST address from advertised address
Date Mon, 05 Mar 2018 02:33:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385504#comment-16385504
] 

ASF GitHub Bot commented on FLINK-8843:
---------------------------------------

GitHub user yanghua opened a pull request:

    https://github.com/apache/flink/pull/5631

    [FLINK-8843][REST] Decouple bind REST address from advertised address

    ## What is the purpose of the change
    
    *This pull request decouples bind REST address from advertised address*
    
    
    ## Brief change log
    
      - *Change the default value from dns `localhost` to `0.0.0.0`*
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes
/ **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yanghua/flink FLINK-8843

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5631.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5631
    
----
commit fb15233414fae2793d77296b990b76f224cacf6e
Author: vinoyang <vinoyang@...>
Date:   2018-03-04T09:01:35Z

    [FLINK-8830][YARN] YarnResourceManager throws NullPointerException

commit e9de543ac111d17658ac5aa3ba78e844c17f578c
Author: vinoyang <vinoyang@...>
Date:   2018-03-05T02:27:13Z

    [FLINK-8843][REST] Decouple bind REST address from advertised address

----


> Decouple bind REST address from advertised address
> --------------------------------------------------
>
>                 Key: FLINK-8843
>                 URL: https://issues.apache.org/jira/browse/FLINK-8843
>             Project: Flink
>          Issue Type: Improvement
>          Components: REST
>    Affects Versions: 1.5.0, 1.6.0
>            Reporter: Till Rohrmann
>            Assignee: vinoyang
>            Priority: Critical
>              Labels: flip-6
>             Fix For: 1.5.0, 1.6.0
>
>
> The {{RestServerEndpoint}} is currently bound to the same address which is also advertised
to the client, namely {{RestOptions#REST_ADDRESS}}. It would be better to start the {{RestServerEndpoint}}
listening on all address by binding to {{0.0.0.0}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message