flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8931) TASK_KILLING is not covered by match in TaskMonitor#whenUnhandled
Date Thu, 22 Mar 2018 14:55:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409656#comment-16409656
] 

ASF GitHub Bot commented on FLINK-8931:
---------------------------------------

Github user yanghua commented on the issue:

    https://github.com/apache/flink/pull/5744
  
    hi @tillrohrmann  you mean change to `stay()`? I have changed to this style. It seems
that in scala FSM  we could not do nothing, it should return task monitor's state.


> TASK_KILLING is not covered by match in TaskMonitor#whenUnhandled
> -----------------------------------------------------------------
>
>                 Key: FLINK-8931
>                 URL: https://issues.apache.org/jira/browse/FLINK-8931
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: vinoyang
>            Priority: Major
>
> Noticed the following :
> {code}
> [WARNING] /a/flink-1.3.3/flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/TaskMonitor.scala:157:
warning: match may not be exhaustive.
> [WARNING] It would fail on the following input: TASK_KILLING
> [WARNING]       msg.status().getState match {
> [WARNING]                    ^
> [WARNING] /a/flink-1.3.3/flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/TaskMonitor.scala:170:
warning: match may not be exhaustive.
> [WARNING] It would fail on the following input: TASK_KILLING
> [WARNING]       msg.status().getState match {
> [WARNING]                    ^
> {code}
> It seems that TASK_KILLING should be covered by the last case.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message