flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8957) Port JMXJobManagerMetricTest to flip6
Date Thu, 22 Mar 2018 16:18:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409800#comment-16409800
] 

ASF GitHub Bot commented on FLINK-8957:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5720#discussion_r176482195
  
    --- Diff: flink-metrics/flink-metrics-jmx/src/test/java/org/apache/flink/runtime/jobmanager/JMXJobManagerMetricTest.java
---
    @@ -92,28 +101,26 @@ public void testJobManagerJMXMetricAccess() throws Exception {
     					true),
     				null));
     
    -			flink.waitForActorsToBeAlive();
    -
    -			flink.submitJobDetached(jobGraph);
    +			ClusterClient<?> client = MINI_CLUSTER_RESOURCE.getClusterClient();
    +			client.setDetached(true);
    +			client.submitJob(jobGraph, JMXJobManagerMetricTest.class.getClassLoader());
     
    -			Future<Object> jobRunning = flink.getLeaderGateway(deadline.timeLeft())
    -				.ask(new TestingJobManagerMessages.WaitForAllVerticesToBeRunning(jobGraph.getJobID()),
deadline.timeLeft());
    -			Await.ready(jobRunning, deadline.timeLeft());
    +			FutureUtils.retrySuccesfulWithDelay(
    +				() -> client.getJobStatus(jobGraph.getJobID()),
    +				Time.milliseconds(10),
    +				deadline,
    +				status -> status == JobStatus.RUNNING,
    --- End diff --
    
    The check whether the job is running does not necessarily mean that all vertices are running.
But I guess what we are waiting for is the initialization of the `CheckpointStatsTracker`.


> Port JMXJobManagerMetricTest to flip6
> -------------------------------------
>
>                 Key: FLINK-8957
>                 URL: https://issues.apache.org/jira/browse/FLINK-8957
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.5.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>             Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message