flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9069) Fix some double semicolons to single semicolons, and update checkstyle
Date Tue, 27 Mar 2018 03:02:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414940#comment-16414940
] 

ASF GitHub Bot commented on FLINK-9069:
---------------------------------------

GitHub user jparkie opened a pull request:

    https://github.com/apache/flink/pull/5769

    [FLINK-9069] Add checkstyle rule to detect multiple consecutive semicolons

    ## What is the purpose of the change
    
    This pull request introduces a new checkstyle rule that detects multiple multiple consecutive
semicolons like those at the end of a Java statement.
    
    ## Brief change log
    
      - Add new checkstyle rule.
      - Fix violations of new checkstyle rule.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jparkie/flink FLINK-9069_jparkie_fix_double_semicolons

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5769.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5769
    
----
commit 61d82b0f51b7f6506b2802c30c561eeee05ae6cc
Author: jparkie <park.jacob.96@...>
Date:   2018-03-26T01:09:25Z

    [FLINK-9069] Add checkstyle rule to detect multiple consecutive semicolons

----


> Fix some double semicolons to single semicolons, and update checkstyle
> ----------------------------------------------------------------------
>
>                 Key: FLINK-9069
>                 URL: https://issues.apache.org/jira/browse/FLINK-9069
>             Project: Flink
>          Issue Type: Task
>          Components: Checkstyle
>            Reporter: Jacob Park
>            Priority: Trivial
>              Labels: starter
>
> As I was reading through the source code, I noticed that there were some double semicolons
";;".
> These should be fixed.
> Finally, the tools/maven/checkstyle.xml should be updated accordingly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message