flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hequn8128 <...@git.apache.org>
Subject [GitHub] flink issue #6233: [FLINK-9696] Deep toString for array/map sql types
Date Sun, 01 Jul 2018 13:20:30 GMT
Github user hequn8128 commented on the issue:

    Hi @snuyanzin , thanks for your PR. The code looks good and the `deepToString()` function
returns result correctly. I could not spot any issues with the implementation. To make the
PR better, I think we can add a test in `CliUtilsTest` to test the `rowToString` function,
since code in the function also has been changed. BTW, the PR template can be done better.
See for PR https://github.com/apache/flink/pull/5811 as an example.
    Best, Hequn


View raw message