flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From snuyanzin <...@git.apache.org>
Subject [GitHub] flink pull request #6223: [FLINK-9688] ATAN2 sql function support
Date Mon, 02 Jul 2018 00:21:16 GMT
Github user snuyanzin commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6223#discussion_r199366673
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala
---
    @@ -1111,6 +1111,53 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
           math.atan(-0.1231231321321321111).toString)
       }
     
    +  @Test
    +  def testAtan2(): Unit = {
    +    testAllApis(
    +      'f25.atan2('f26),
    +      "f25.atan2(f26)",
    +      "ATAN2(f25, f26)",
    +      math.atan2(0.42.toByte, 0.toByte).toString)
    +
    +
    --- End diff --
    
    Thank you for that catch. 
    blank line removed


---

Mime
View raw message