flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #6201: [FLINK-8866][Table API & SQL] Add support for unif...
Date Wed, 04 Jul 2018 08:24:50 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6201#discussion_r200045769
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/connector/TableConnectorFactory.scala
---
    @@ -16,21 +16,18 @@
      * limitations under the License.
      */
     
    -package org.apache.flink.table.sources
    +package org.apache.flink.table.connector
     
     import java.util
     
    -/**
    -  * A factory to create a [[TableSource]]. This factory is used with Java's Service Provider
    -  * Interfaces (SPI) for discovering. A factory is called with a set of normalized properties
that
    -  * describe the desired table source. The factory allows for matching to the given set
of
    -  * properties and creating a configured [[TableSource]] accordingly.
    -  *
    -  * Classes that implement this interface need to be added to the
    -  * "META_INF/services/org.apache.flink.table.sources.TableSourceFactory' file of a JAR
file in
    -  * the current classpath to be found.
    -  */
    -trait TableSourceFactory[T] {
    +trait TableConnectorFactory[T] {
    --- End diff --
    
    @suez1224 Actually, I liked `CREATE TABLE` because it is closer to SQL. The reason why
I proposed `TableFactory` was because the factory does much more than just constructing a
connector. It also performs schema validation, format discovery and so on. 


---

Mime
View raw message