flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zjffdu <...@git.apache.org>
Subject [GitHub] flink pull request #6245: [FLINK-9718][scala-shell]. Add enviroment variable...
Date Wed, 04 Jul 2018 09:13:57 GMT
Github user zjffdu commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6245#discussion_r200060027
  
    --- Diff: flink-scala-shell/start-script/start-scala-shell.sh ---
    @@ -19,6 +19,9 @@
     
     # from scala-lang 2.10.4
     
    +# Uncomment the following line to enable remote debug
    +# export FLINK_SCALA_SHELL_JAVA_OPTS="-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5005"
    --- End diff --
    
    Sorry @yanghua I still think using bool flag is not proper. Regarding `hiding the details
of remote debug info`, I mean bool flag only control whether to enable remote debug, but does't
control how, such as which port to listen.  If we introduce this bool flag,  we will use 2
env variable to control whether and how to remote debug which is too verbose to me. 


---

Mime
View raw message