flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yanghua <...@git.apache.org>
Subject [GitHub] flink pull request #6245: [FLINK-9718][scala-shell]. Add enviroment variable...
Date Wed, 04 Jul 2018 11:09:36 GMT
Github user yanghua commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6245#discussion_r200091741
  
    --- Diff: flink-scala-shell/start-script/start-scala-shell.sh ---
    @@ -19,6 +19,9 @@
     
     # from scala-lang 2.10.4
     
    +# Uncomment the following line to enable remote debug
    +# export FLINK_SCALA_SHELL_JAVA_OPTS="-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5005"
    --- End diff --
    
    OK, I just think using a comment which may been ignored by the user. And using a bool
flag which also can control whether add  `FLINK_SCALA_SHELL_JAVA_OPTS ` as a option to java
command or not. Please feel free to follow your idea.


---

Mime
View raw message