flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #6264: [FLINK-8558] [table] Add unified format interfaces...
Date Tue, 10 Jul 2018 11:34:36 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6264#discussion_r201309003
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/DefinedFieldMapping.scala
---
    @@ -50,7 +50,8 @@ trait DefinedFieldMapping {
         * type. It can also provide a mapping for fields which are not in the [[TableSchema]]
to make
         * fields in the physical [[TypeInformation]] accessible for a [[TimestampExtractor]].
         *
    -    * @return A mapping from [[TableSchema]] fields to [[TypeInformation]] fields.
    +    * @return A mapping from [[TableSchema]] fields to [[TypeInformation]] fields or
    --- End diff --
    
    This is public API that we cannot change easily. I think the reason why Fabian chose null
here is also for interoperability between Scala and Java.


---

Mime
View raw message