flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink issue #6231: [FLINK-9694] Potentially NPE in CompositeTypeSerializerCo...
Date Wed, 11 Jul 2018 11:56:27 GMT
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/6231
  
    This doesn't look correct to me, the serializer should always be non-null, and silently
dropping null serializers most likely just causes other problems.
    
    Did you actually run into this NPE when using Flink, or did you explicitly call the constructor
for demonstration purposes?
    
    As far as I can tell the code in `CRowSerializer` is either broken or a not adequately
documented hack.
    It is at the very least untested as this NPE _always_ occur when this constructor is used.
    
    @tzulitai Why exactly is this [constructor](https://github.com/apache/flink/blob/master/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/types/CRowSerializer.scala#L123)
necessary?


---

Mime
View raw message