flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #6304: [FLINK-9801][build] Add missing example dependenci...
Date Thu, 12 Jul 2018 07:43:20 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6304#discussion_r201937327
  
    --- Diff: flink-dist/pom.xml ---
    @@ -140,6 +140,22 @@ under the License.
     			</exclusions>
     		</dependency>
     
    +		<dependency>
    --- End diff --
    
    There is a section further down on the POM, with a comment "dependencies for "/examples"
in scope provided. How about moving these entries there, then we get comments for "why it
is like that" for free...


---

Mime
View raw message