flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yanghua <...@git.apache.org>
Subject [GitHub] flink issue #5954: [FLINK-9276] Improve error message when TaskManager fails
Date Thu, 12 Jul 2018 11:38:10 GMT
Github user yanghua commented on the issue:

    https://github.com/apache/flink/pull/5954
  
    @tillrohrmann That's all right. I know you are very busy. Just a little question, I have
reviewed PR(#6202). I saw it used `Exception`, and there is a suggestion from Stephan in May
7 : 
    
    ```
    I would use Throwable in the signatures. It may always be that some Error is the cause
(class not found, etc.)
    ```
    
    So I replaced the `Exception ` to `Throwable` in this PR, do you think it can be consider?
If not, I would close this PR. 


---

Mime
View raw message