Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202018873
--- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
---
@@ -386,10 +386,10 @@ private ClusterSpecification createClusterSpecification(Configuration
configurat
}
// JobManager Memory
- final int jobManagerMemoryMB = MemorySize.parse(configuration.getString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY)).getMebiBytes();
+ final int jobManagerMemoryMB = MemorySize.parse(configuration.getString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY),
MemorySize.MemoryUnit.MEGA_BYTES).getMebiBytes();
--- End diff --
I think the problem here would be that we would need to get back to MB as a default unit
for this option. Or am I wrong here? The whole idea for introducing the new option was to
switch to bytes as a default one, if none provided.
---
|