flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StefanRRichter <...@git.apache.org>
Subject [GitHub] flink pull request #6313: [FLINK-9701] Add TTL in state descriptors
Date Thu, 12 Jul 2018 13:25:12 GMT
Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6313#discussion_r202032512
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/state/StateDescriptor.java
---
    @@ -92,6 +93,10 @@
     	@Nullable
     	private String queryableStateName;
     
    +	/** Name for queries against state created from this StateDescriptor. */
    +	@Nullable
    +	private StateTtlConfiguration ttlConfig;
    --- End diff --
    
    I would suggest to prefer @Nonnull and a `StateTtlConfiguration` that represents `disabled
ttl`. So that the getter will also not return `null` and code can drop `null` checks.


---

Mime
View raw message