Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202057663
--- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
---
@@ -386,10 +386,10 @@ private ClusterSpecification createClusterSpecification(Configuration
configurat
}
// JobManager Memory
- final int jobManagerMemoryMB = MemorySize.parse(configuration.getString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY)).getMebiBytes();
+ final int jobManagerMemoryMB = MemorySize.parse(configuration.getString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY),
MemorySize.MemoryUnit.MEGA_BYTES).getMebiBytes();
--- End diff --
@dawidwys Why is it not enough?
> When obtaining a value from the configuration via Configuration.getValue(ConfigOption),
the deprecated keys will be checked in the order provided to this method. The first key for
which a value is found will be used - that value will be returned.
---
|