flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StefanRRichter <...@git.apache.org>
Subject [GitHub] flink pull request #6313: [FLINK-9701] Add TTL in state descriptors
Date Thu, 12 Jul 2018 14:36:01 GMT
Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6313#discussion_r202058484
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java
---
    @@ -240,7 +243,7 @@ private boolean hasRegisteredState() {
     	}
     
     	@Override
    -	public <N, SV, S extends State, IS extends S> IS createState(
    +	public <N, SV, S extends State, IS extends S> IS createInternalState(
    --- End diff --
    
    Why are we adding `Internal` here? I would suggest to call the method `create(Internal?)KeyValueState`,
because there will also be other state in the future (timers). 


---

Mime
View raw message