flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink issue #6332: [FLINK-8858] [sql-client] Add support for INSERT INTO in ...
Date Sat, 14 Jul 2018 07:11:20 GMT
Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/6332
  
    Thanks for the review @pnowojski. I agree that we should support `flink-cli < query01.sql`
or `echo "INSERT INTO bar SELECT * FROM foo" | flink-cli`. However, I would move this to a
separate issue because I'm not sure how well we support multilines and EOF right now. With
the `-u` flag the user also gets the correct error code after the submission, with `flink-cli
< query01.sql` the CLI would either stay in interactive mode or always return success.
I would keep the `-u` flag for now for testing purposes. We could remove it from the CLI help
and leave it as an internal parameter for now. What do you think?


---

Mime
View raw message