flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #6332: [FLINK-8858] [sql-client] Add support for INSERT I...
Date Sat, 14 Jul 2018 17:15:57 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6332#discussion_r202520454
  
    --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
---
    @@ -354,6 +398,23 @@ private void callSelect(SqlCommandCall cmdCall) {
     		}
     	}
     
    +	private boolean callInsertInto(SqlCommandCall cmdCall) {
    +		terminal.writer().println(CliStrings.messageInfo(CliStrings.MESSAGE_SUBMITTING_STATEMENT).toAnsi());
    +		terminal.flush();
    +
    +		try {
    +			final ProgramTargetDescriptor programTarget = executor.executeUpdate(context, cmdCall.operands[0]);
    +			terminal.writer().println(CliStrings.messageInfo(CliStrings.MESSAGE_STATEMENT_SUBMITTED).toAnsi());
    --- End diff --
    
    hmmm, what about
    ```
    terminal.writer().println(CliStrings.messageInfo(CliStrings.MESSAGE_STATEMENT_SUBMITTED).toAnsi());
    terminal.writer().println(programTarget.toString())
    ```?


---

Mime
View raw message