flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #6323: [FLINK-8558] [FLINK-8866] [table] Finalize unified...
Date Sat, 14 Jul 2018 17:37:57 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6323#discussion_r202520938
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFactory.scala
---
    @@ -16,14 +16,14 @@
      * limitations under the License.
      */
     
    -package org.apache.flink.table.connectors
    +package org.apache.flink.table.factories
     
     import java.util
     
     /**
       * Common trait for all properties-based discoverable table factories.
       */
    -trait DiscoverableTableFactory {
    +trait TableFactory {
    --- End diff --
    
    I am not happy but I can not think about something better :( `Factory` is way to generic.
It implies that this is THE Factory, THE One Factory To Rule Them All and that's not true.
There are plenty of other factories in `flink-table`. `Table` prefix as you confirmed is just
a package prefix, thus doesn't improve anything :(


---

Mime
View raw message