flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #6323: [FLINK-8558] [FLINK-8866] [table] Finalize unified...
Date Sat, 14 Jul 2018 17:52:07 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6323#discussion_r202520986
  
    --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/SourceSink.java
---
    @@ -51,16 +51,10 @@ public void addProperties(DescriptorProperties properties) {
     	}
     
     	public Source toSource() {
    -		final Map<String, String> newProperties = new HashMap<>(properties);
    -		newProperties.replace(TableDescriptorValidator.TABLE_TYPE(),
    -				TableDescriptorValidator.TABLE_TYPE_VALUE_SOURCE());
    --- End diff --
    
    I'm just asking because I can not find what code has replaced them. Or there were some
dead code?


---

Mime
View raw message