flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...
Date Thu, 19 Jul 2018 05:30:26 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6120#discussion_r203605524
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
---
    @@ -545,15 +543,15 @@ public IntervalJoined(
     
     			TypeInformation<OUT> resultType = TypeExtractor.getBinaryOperatorReturnType(
     				cleanedUdf,
    -				ProcessJoinFunction.class,    // ProcessJoinFunction<IN1, IN2, OUT>
    -				0,     //					    0    1    2
    +				ProcessJoinFunction.class,
    +				0,
     				1,
     				2,
    -				TypeExtractor.NO_INDEX,         // output arg indices
    -				left.getType(),                 // input 1 type information
    -				right.getType(),                // input 2 type information
    -				INTERVAL_JOIN_FUNC_NAME ,
    -				false
    +				TypeExtractor.NO_INDEX,
    +				left.getType(),
    +				right.getType(),
    +				Utils.getCallLocationName(),
    +				true
    --- End diff --
    
    Just saw that this should be false. Will correct that.


---

Mime
View raw message