flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #6392: [FLINK-9694][table] Fix NPE in CRowSerializerConfi...
Date Tue, 24 Jul 2018 10:05:39 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6392#discussion_r204696678
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerConfigSnapshot.java
---
    @@ -46,8 +46,6 @@
     	public CompositeTypeSerializerConfigSnapshot() {}
     
     	public CompositeTypeSerializerConfigSnapshot(TypeSerializer<?>... nestedSerializers)
{
    -		Preconditions.checkNotNull(nestedSerializers);
    --- End diff --
    
    Ops, scratch that. It wasn't dead code, `CompositeTypeSerializerConfigSnapshot( (TypeSerializer<>[])
null)` would probably trigger this condition. Reverted


---

Mime
View raw message