flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...
Date Tue, 24 Jul 2018 11:49:41 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6399#discussion_r204718919
  
    --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java
---
    @@ -481,10 +479,6 @@ public void testCallsForwardedToNonPartitionedBackend() throws Exception
{
     						env.getTaskKvStateRegistry());
     	}
     
    -	static Environment getMockEnvironment() {
    -		return getMockEnvironment(new File[] { new File(System.getProperty("java.io.tmpdir"))
});
    -	}
    -
     	static Environment getMockEnvironment(File[] tempDirs) {
    --- End diff --
    
    we could change this to a vararg method; then we could simplify calls like `getMockEnvironment(new
File[] { tempFolder.newFolder() });`.


---

Mime
View raw message