flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...
Date Tue, 24 Jul 2018 11:49:41 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6399#discussion_r204719565
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java
---
    @@ -218,7 +224,7 @@ public void TestAnonymousClass() throws IOException {
     
     	@Test
     	public void TestExtendIdentifier() throws IOException {
    -		File out = new File(System.getProperty("java.io.tmpdir"), "jarcreatortest.jar");
    +		File out = tempFolder.newFile("jarcreatortest.jar");
    --- End diff --
    
    to preserve the existing behavior of passing a file that does not exist, do this instead:
    ```
    File out = new File(tempFolder.getRoot(), "jarcreatortest.jar");
    ```
    
    Also applies to the other tests in this file.


---

Mime
View raw message