flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6846) Add TIMESTAMPADD supported in TableAPI
Date Sun, 01 Jul 2018 15:02:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529122#comment-16529122
] 

ASF GitHub Bot commented on FLINK-6846:
---------------------------------------

Github user walterddr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6188#discussion_r199352237
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
---
    @@ -1029,6 +1029,29 @@ object temporalOverlaps {
         TemporalOverlaps(leftTimePoint, leftTemporal, rightTimePoint, rightTemporal)
       }
     }
    +/**
    +  * Adds a (signed) integer interval to a timestamp. The unit for the interval is given
    +  * by the unit argument, which should be one of the following values: "SECOND", "MINUTE",
    +  * "HOUR", "DAY", "WEEK", "MONTH", "QUARTER" or "YEAR".
    +  *
    +  * e.g. timestampAdd("WEEK", 1, '2003-01-02'.toDate) leads to "2003-01-09".
    +  */
    +object timestampAdd {
    +
    +  /**
    +    * Adds a (signed) integer interval to a timestamp. The unit for the interval is given
    +    * by the unit argument, which should be one of the following values: "SECOND", "MINUTE",
    +    * "HOUR", "DAY", "WEEK", "MONTH", "QUARTER" or "YEAR".
    +    *
    +    * e.g. timestampAdd("WEEK", 1, '2003-01-02'.toDate) leads to "2003-01-09".
    +  */
    +  def apply(
    +      unit: Expression,
    --- End diff --
    
    +1 for this approach that directly specifies the interval literals. 
    
    Regarding Quarter. It seems like a very old implementation and we should probably use
`"1970-01-01".toDate.extract(TimeIntervalUnit.QUARTER)` to make it consistent with all other
time unit extractions. What do you guys think?
    
    I just tried it out by modifying the `Extract` method and it seems working perfectly.


> Add TIMESTAMPADD supported in TableAPI
> --------------------------------------
>
>                 Key: FLINK-6846
>                 URL: https://issues.apache.org/jira/browse/FLINK-6846
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>    Affects Versions: 1.4.0
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>            Priority: Major
>              Labels: pull-request-available, starter
>
> See FLINK-6811 for detail.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message