flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core
Date Thu, 19 Jul 2018 05:31:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548808#comment-16548808
] 

ASF GitHub Bot commented on FLINK-7251:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6120#discussion_r203605524
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
---
    @@ -545,15 +543,15 @@ public IntervalJoined(
     
     			TypeInformation<OUT> resultType = TypeExtractor.getBinaryOperatorReturnType(
     				cleanedUdf,
    -				ProcessJoinFunction.class,    // ProcessJoinFunction<IN1, IN2, OUT>
    -				0,     //					    0    1    2
    +				ProcessJoinFunction.class,
    +				0,
     				1,
     				2,
    -				TypeExtractor.NO_INDEX,         // output arg indices
    -				left.getType(),                 // input 1 type information
    -				right.getType(),                // input 2 type information
    -				INTERVAL_JOIN_FUNC_NAME ,
    -				false
    +				TypeExtractor.NO_INDEX,
    +				left.getType(),
    +				right.getType(),
    +				Utils.getCallLocationName(),
    +				true
    --- End diff --
    
    Just saw that this should be false. Will correct that.


> Merge the flink-java8 project into flink-core
> ---------------------------------------------
>
>                 Key: FLINK-7251
>                 URL: https://issues.apache.org/jira/browse/FLINK-7251
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>            Reporter: Stephan Ewen
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message