flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8858) Add support for INSERT INTO in SQL Client
Date Sat, 14 Jul 2018 06:11:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544075#comment-16544075
] 

ASF GitHub Bot commented on FLINK-8858:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6332#discussion_r202507424
  
    --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
---
    @@ -85,6 +86,9 @@ public CliClient(SessionContext context, Executor executor) {
     			terminal = TerminalBuilder.builder()
     				.name(CliStrings.CLI_NAME)
     				.build();
    +			// make space from previous output and test the writer
    +			terminal.writer().println();
    --- End diff --
    
    It makes the output on the terminal nicer. We don't know what has been printed before.
This starts a terminal session. The output looks now like:
    
    ```
    No default environment specified.
    Searching for '/Users/twalthr/flink/flink/flink-dist/target/flink-1.6-SNAPSHOT-bin/flink-1.6-SNAPSHOT/conf/sql-client-defaults.yaml'...found.
    Reading default environment from: file:/Users/twalthr/flink/flink/flink-dist/target/flink-1.6-SNAPSHOT-bin/flink-1.6-SNAPSHOT/conf/sql-client-defaults.yaml
    No session environment specified.
    
    [INFO] Executing the following statement:
    INSERT INTO MyTableName SELECT * FROM MyTableName
    [INFO] Submitting SQL update statement to the cluster...
    [INFO] Table update statement has been successfully submitted to the cluster:
    Cluster ID: StandaloneClusterId / Job ID: fab21f0632da36f9236c343c2850c71d
    For the current job status visit: http://localhost:8081
    
    Shutting down executor...done.
    ```


> Add support for INSERT INTO in SQL Client
> -----------------------------------------
>
>                 Key: FLINK-8858
>                 URL: https://issues.apache.org/jira/browse/FLINK-8858
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>    Affects Versions: 1.6.0
>            Reporter: Renjie Liu
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>
> The current design of SQL Client embedded mode doesn't support long running queries.
It would be useful for simple jobs that can be expressed in a single sql statement if we can
submit sql statements stored in files as long running queries. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message