flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8858) Add support for INSERT INTO in SQL Client
Date Sat, 14 Jul 2018 06:43:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544087#comment-16544087
] 

ASF GitHub Bot commented on FLINK-8858:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6332#discussion_r202507962
  
    --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
---
    @@ -329,14 +341,46 @@ public void stop(SessionContext session) {
     		}
     	}
     
    -	private <T> ResultDescriptor executeQueryInternal(ExecutionContext<T> context,
String query) {
    +	private <C> ProgramTargetDescriptor executeUpdateInternal(ExecutionContext<C>
context, String statement) {
    +		final ExecutionContext.EnvironmentInstance envInst = context.createEnvironmentInstance();
    +
    +		// apply update statement
    --- End diff --
    
    On one side yes but on the other side it allows to read the comments from top to bottom
and know what the method is doing without having to look at the actual code.


> Add support for INSERT INTO in SQL Client
> -----------------------------------------
>
>                 Key: FLINK-8858
>                 URL: https://issues.apache.org/jira/browse/FLINK-8858
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>    Affects Versions: 1.6.0
>            Reporter: Renjie Liu
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>
> The current design of SQL Client embedded mode doesn't support long running queries.
It would be useful for simple jobs that can be expressed in a single sql statement if we can
submit sql statements stored in files as long running queries. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message