flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8858) Add support for INSERT INTO in SQL Client
Date Sat, 14 Jul 2018 17:14:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544272#comment-16544272
] 

ASF GitHub Bot commented on FLINK-8858:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6332#discussion_r202520415
  
    --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
---
    @@ -173,55 +180,92 @@ public void open() {
     			if (line == null || line.equals("")) {
     				continue;
     			}
    +			parseAndCall(line);
    +		}
    +	}
     
    -			final SqlCommandCall cmdCall = SqlCommandParser.parse(line);
    +	/**
    +	 * Submits a SQL update statement and prints status information and/or errors on the
terminal.
    +	 *
    +	 * @param statement SQL update statement
    +	 * @return flag to indicate if the submission was successful or not
    +	 */
    +	public boolean submitUpdate(String statement) {
    --- End diff --
    
    Hmmm, that's bad :( Is it hard to start local flink mini cluster and execute `cli` process
from `JUnit` test? (Maybe as a follow up after feature freeze)


> Add support for INSERT INTO in SQL Client
> -----------------------------------------
>
>                 Key: FLINK-8858
>                 URL: https://issues.apache.org/jira/browse/FLINK-8858
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>    Affects Versions: 1.6.0
>            Reporter: Renjie Liu
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>
> The current design of SQL Client embedded mode doesn't support long running queries.
It would be useful for simple jobs that can be expressed in a single sql statement if we can
submit sql statements stored in files as long running queries. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message