flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8858) Add support for INSERT INTO in SQL Client
Date Sat, 14 Jul 2018 17:16:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544273#comment-16544273
] 

ASF GitHub Bot commented on FLINK-8858:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6332#discussion_r202520454
  
    --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
---
    @@ -354,6 +398,23 @@ private void callSelect(SqlCommandCall cmdCall) {
     		}
     	}
     
    +	private boolean callInsertInto(SqlCommandCall cmdCall) {
    +		terminal.writer().println(CliStrings.messageInfo(CliStrings.MESSAGE_SUBMITTING_STATEMENT).toAnsi());
    +		terminal.flush();
    +
    +		try {
    +			final ProgramTargetDescriptor programTarget = executor.executeUpdate(context, cmdCall.operands[0]);
    +			terminal.writer().println(CliStrings.messageInfo(CliStrings.MESSAGE_STATEMENT_SUBMITTED).toAnsi());
    --- End diff --
    
    hmmm, what about
    ```
    terminal.writer().println(CliStrings.messageInfo(CliStrings.MESSAGE_STATEMENT_SUBMITTED).toAnsi());
    terminal.writer().println(programTarget.toString())
    ```?


> Add support for INSERT INTO in SQL Client
> -----------------------------------------
>
>                 Key: FLINK-8858
>                 URL: https://issues.apache.org/jira/browse/FLINK-8858
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>    Affects Versions: 1.6.0
>            Reporter: Renjie Liu
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>
> The current design of SQL Client embedded mode doesn't support long running queries.
It would be useful for simple jobs that can be expressed in a single sql statement if we can
submit sql statements stored in files as long running queries. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message