flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9280) Extend JobSubmitHandler to accept jar files
Date Mon, 02 Jul 2018 10:43:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529700#comment-16529700

ASF GitHub Bot commented on FLINK-9280:

Github user zentol commented on a diff in the pull request:

    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/JobSubmitHandlerTest.java
    @@ -119,15 +113,17 @@ public void testSuccessfulJobSubmission() throws Exception {
    -		DispatcherGateway mockGateway = mock(DispatcherGateway.class);
    -		when(mockGateway.getHostname()).thenReturn("localhost");
    -		when(mockGateway.getBlobServerPort(any(Time.class))).thenReturn(CompletableFuture.completedFuture(blobServer.getPort()));
    -		when(mockGateway.submitJob(any(JobGraph.class), any(Time.class))).thenReturn(CompletableFuture.completedFuture(Acknowledge.get()));
    -		GatewayRetriever<DispatcherGateway> mockGatewayRetriever = mock(GatewayRetriever.class);
    +		TestingDispatcherGateway.Builder builder = new TestingDispatcherGateway.Builder();
    --- End diff --
    This block is written the way it is since methods that the `TestingDispatcherGateway.Builder`
inherits return a `TestingRestfulGateway.Builder`, which also applies to `build`.
    it's a bit cumbersome, but I couldn't find a solution that doesn't include copying the
entire `TestingRestfulGateway.Builder`.

> Extend JobSubmitHandler to accept jar files
> -------------------------------------------
>                 Key: FLINK-9280
>                 URL: https://issues.apache.org/jira/browse/FLINK-9280
>             Project: Flink
>          Issue Type: New Feature
>          Components: Job-Submission, REST
>    Affects Versions: 1.5.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.6.0, 1.5.1
> The job submission through the CLI first uploads all require jars to the blob server,
sets the blob keys in the jobgraph, and then uploads this graph to The {{JobSubmitHandler}}
which submits it to the Dispatcher.
> This process has the downside that it requires jars to be uploaded to the blobserver
before submitting the job graph, which does not happen via REST.
> I propose an extension to the the {{JobSubmitHandler}} to also accept an optional list
of jar files, that were previously uploaded through the {{JarUploadHandler}}. If present,
the handler would upload these jars to the blobserver and set the blob keys.

This message was sent by Atlassian JIRA

View raw message