[ https://issues.apache.org/jira/browse/FLINK-9311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531854#comment-16531854
]
ASF GitHub Bot commented on FLINK-9311:
---------------------------------------
GitHub user Xeli opened a pull request:
https://github.com/apache/flink/pull/6248
[FLINK-9311] [pubsub] Added PubSub connector with support for checkpointing
## What is the purpose of the change
Adding a PubSub connector with support for Checkpointing
## Verifying this change
This change added tests and can be verified as follows:
- *Added unit tests*
- *Manually verified the connector (without Checkpointing) on an actual PubSub topic
and subscription.*
**Is there a need for integration tests? I did not see any for the other connectors.
What is a good way of testing the checkpointing / exactly-once behavior?**
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes, Google Cloud Sdk for PubSub
(**Does this need to be shaded?**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): don't know, don't think
so
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: yes, checkpointing
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? JavaDocs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Xeli/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6248.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6248
----
commit dddbe671a0d663045110b89ad9bb85ce9a7e7051
Author: Richard Deurwaarder <richard@...>
Date: 2018-05-26T12:59:32Z
[FLINK-9311] [pubsub] Add PubSubSource without checkpointing
commit 30fab0fd6810691f22ff583ce3f942e247d9fe45
Author: Richard Deurwaarder <richard@...>
Date: 2018-07-03T17:34:02Z
[FLINK-9311] [pubsub] Add checkpointing to PubSubSource
----
> PubSub connector
> ----------------
>
> Key: FLINK-9311
> URL: https://issues.apache.org/jira/browse/FLINK-9311
> Project: Flink
> Issue Type: New Feature
> Components: Streaming Connectors
> Reporter: Richard Deurwaarder
> Priority: Minor
> Labels: pull-request-available
>
> I would like start adding some google cloud connectors starting with a PubSub Source.
I have a basic implementation ready but I want it to be able to:
> * easily scale up (should I have it extend RichParallelSourceFunction for this?)
> * Make it easier to provide the google cloud credentials. This would require being able
to send some json string / ServiceAccount to the nodes when starting up this source.
> Could this be something that would be useful for others and added to the flink connectors
repo?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
|