flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9380) Failing end-to-end tests should not clean up logs
Date Mon, 09 Jul 2018 19:58:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537482#comment-16537482
] 

ASF GitHub Bot commented on FLINK-9380:
---------------------------------------

GitHub user deepaks4077 opened a pull request:

    https://github.com/apache/flink/pull/6289

    [FLINK-9380]: Modified end to end test runner script to stop deleting logs if tests fail

    ## What is the purpose of the change
    
    This pull request modifies a couple of end to end test runner scripts to save logs of
failed tests. Currently, logs are deleted irrespective of a test's result, making it difficult
to debug failed tests. 
    
    ## Brief change log
    
      - *Modified EXIT trap to only cleanup the process instead of cleaning up logs as well*
      - *Added SIGINT trap to clean up everything on test process interrupt*
      - *Export TEST_DATA_DIR inside test-runner-common.sh _instead of common.sh_. This allows
all test scripts to inherit this variable instead of generating it again on their own via
common.sh*
      - *Split operations inside cleanup() into cleanup_proc() and cleanup_files()*
    
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes
/ **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not
documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/deepaks4077/flink FLINK-9380

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6289.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6289
    
----
commit 81d5757c1036d1a9172dc56963a4169003fa74e8
Author: Deepak Sharnma <deepaks4077@...>
Date:   2018-07-09T19:37:58Z

    [FLINK-9380]: Modified test runner script to stop deleting logs if tests fail

----


> Failing end-to-end tests should not clean up logs
> -------------------------------------------------
>
>                 Key: FLINK-9380
>                 URL: https://issues.apache.org/jira/browse/FLINK-9380
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.5.0, 1.6.0
>            Reporter: Till Rohrmann
>            Assignee: Deepak Sharma
>            Priority: Critical
>              Labels: pull-request-available, test-stability
>             Fix For: 1.5.2, 1.6.0
>
>
> Some of the end-to-end tests clean up their logs also in the failure case. This makes
debugging and understanding the problem extremely difficult. Ideally, the scripts says where
it stored the respective logs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message