flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9614) Improve the error message for Compiler#compile
Date Sat, 21 Jul 2018 08:49:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551586#comment-16551586
] 

ASF GitHub Bot commented on FLINK-9614:
---------------------------------------

GitHub user zhangminglei opened a pull request:

    https://github.com/apache/flink/pull/6380

    [FLINK-9614] [table] Improve the error message for Compiler#compile

    ## What is the purpose of the change
    Improve the error message for Compiler#compile

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhangminglei/flink flink-9614-improve-error

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6380.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6380
    
----
commit f4406622c67df9212c545d36b3572e774acf1df7
Author: zhangminglei <zml13856086071@...>
Date:   2018-07-21T08:39:16Z

    [FLINK-9614] [table] Improve the error message for Compiler#compile

----


> Improve the error message for Compiler#compile
> ----------------------------------------------
>
>                 Key: FLINK-9614
>                 URL: https://issues.apache.org/jira/browse/FLINK-9614
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API &amp; SQL
>    Affects Versions: 1.5.0
>            Reporter: zhangminglei
>            Assignee: zhangminglei
>            Priority: Major
>              Labels: pull-request-available
>
> When the below sql has too long. Like
> case when .... case when .....
>  when host in ('114.67.56.94','114.67.56.102','114.67.56.103','114.67.56.106','114.67.56.107','183.60.220.231','183.60.220.232','183.60.219.247','114.67.56.94','114.67.56.102','114.67.56.103','114.67.56.106','114.67.56.107','183.60.220.231','183.60.220.232','183.60.219.247','114.67.56.94','114.67.56.102','114.67.56.103','114.67.56.106','114.67.56.107','183.60.220.231','183.60.220.232','183.60.219.247')
then 'condition'
> Then cause the {{StackOverflowError}}. And the current code is below, we can solve this
by setting -Xss 20m, instead of {{This is a bug......}}
> {code:java}
> trait Compiler[T] {
>   @throws(classOf[CompileException])
>   def compile(cl: ClassLoader, name: String, code: String): Class[T] = {
>     require(cl != null, "Classloader must not be null.")
>     val compiler = new SimpleCompiler()
>     compiler.setParentClassLoader(cl)
>     try {
>       compiler.cook(code)
>     } catch {
>       case t: Throwable =>
>         throw new InvalidProgramException("Table program cannot be compiled. " +
>           "This is a bug. Please file an issue.", t)
>     }
>     compiler.getClassLoader.loadClass(name).asInstanceOf[Class[T]]
>   }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message