flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9679) Implement AvroSerializationSchema
Date Wed, 18 Jul 2018 21:27:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548425#comment-16548425
] 

ASF GitHub Bot commented on FLINK-9679:
---------------------------------------

Github user medcv commented on the issue:

    https://github.com/apache/flink/pull/6259
  
    @dawidwys  Thanks!
    
    As far as I dog on Confluent code, their api needs `subject` to retrieve the Schema Id
and version and it should be provided by consumer. 
    
    https://github.com/confluentinc/schema-registry/blob/master/client/src/main/java/io/confluent/kafka/schemaregistry/client/SchemaRegistryClient.java#L30
    
    Purpose of new commit is to address your first comments by removing `topic` name in the
serialization constructor and replace it with `subject`. So this way serializer doesn't need
to know about the `topic` name.
    
    If you still see issues with this approach I would appreciate it if you help me to find
a better solution.
    
    
     



> Implement AvroSerializationSchema
> ---------------------------------
>
>                 Key: FLINK-9679
>                 URL: https://issues.apache.org/jira/browse/FLINK-9679
>             Project: Flink
>          Issue Type: Improvement
>    Affects Versions: 1.6.0
>            Reporter: Yazdan Shirvany
>            Assignee: Yazdan Shirvany
>            Priority: Major
>              Labels: pull-request-available
>
> Implement AvroSerializationSchema using Confluent Schema Registry



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message