flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9701) Activate TTL in state descriptors
Date Thu, 12 Jul 2018 13:26:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541633#comment-16541633
] 

ASF GitHub Bot commented on FLINK-9701:
---------------------------------------

Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6313#discussion_r202032512
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/state/StateDescriptor.java
---
    @@ -92,6 +93,10 @@
     	@Nullable
     	private String queryableStateName;
     
    +	/** Name for queries against state created from this StateDescriptor. */
    +	@Nullable
    +	private StateTtlConfiguration ttlConfig;
    --- End diff --
    
    I would suggest to prefer @Nonnull and a `StateTtlConfiguration` that represents `disabled
ttl`. So that the getter will also not return `null` and code can drop `null` checks.


> Activate TTL in state descriptors
> ---------------------------------
>
>                 Key: FLINK-9701
>                 URL: https://issues.apache.org/jira/browse/FLINK-9701
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>            Reporter: Andrey Zagrebin
>            Assignee: Andrey Zagrebin
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message