flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9701) Activate TTL in state descriptors
Date Thu, 12 Jul 2018 14:37:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541744#comment-16541744
] 

ASF GitHub Bot commented on FLINK-9701:
---------------------------------------

Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6313#discussion_r202058484
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java
---
    @@ -240,7 +243,7 @@ private boolean hasRegisteredState() {
     	}
     
     	@Override
    -	public <N, SV, S extends State, IS extends S> IS createState(
    +	public <N, SV, S extends State, IS extends S> IS createInternalState(
    --- End diff --
    
    Why are we adding `Internal` here? I would suggest to call the method `create(Internal?)KeyValueState`,
because there will also be other state in the future (timers). 


> Activate TTL in state descriptors
> ---------------------------------
>
>                 Key: FLINK-9701
>                 URL: https://issues.apache.org/jira/browse/FLINK-9701
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>            Reporter: Andrey Zagrebin
>            Assignee: Andrey Zagrebin
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message