flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9707) LocalFileSystem does not support concurrent directory creations
Date Wed, 04 Jul 2018 01:38:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532132#comment-16532132
] 

ASF GitHub Bot commented on FLINK-9707:
---------------------------------------

Github user lamber-ken commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6243#discussion_r199989644
  
    --- Diff: flink-core/src/main/java/org/apache/flink/core/fs/local/LocalFileSystem.java
---
    @@ -254,7 +254,7 @@ else if (file.exists() && !file.isDirectory()) {
     		}
     		else {
     			File parent = file.getParentFile();
    -			return (parent == null || mkdirsInternal(parent)) && file.mkdir();
    +			return (parent == null || mkdirsInternal(parent)) && (file.mkdir() || file.isDirectory());
    --- End diff --
    
    the `file.isDirectory()` always return false, isn't it?


> LocalFileSystem does not support concurrent directory creations
> ---------------------------------------------------------------
>
>                 Key: FLINK-9707
>                 URL: https://issues.apache.org/jira/browse/FLINK-9707
>             Project: Flink
>          Issue Type: Improvement
>          Components: FileSystem
>    Affects Versions: 1.5.0, 1.6.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.6.0, 1.5.1
>
>
> The {{LocalFileSystem}} does not support concurrent directory creations. The consequence
is that file system operations fail.
> I think the culprit is the following line: https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/core/fs/local/LocalFileSystem.java#L257



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message