flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sihua Zhou (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9736) Potential null reference in KeyGroupPartitionedPriorityQueue#poll()
Date Wed, 04 Jul 2018 13:09:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532726#comment-16532726
] 

Sihua Zhou commented on FLINK-9736:
-----------------------------------

Hi [~yuzhihong@gmail.com] I think this might look like a non issue, because `heapOfKeyGroupHeaps`
is a heap-of-heap that created on the constructer of {{KeyGroupPartitionedPriorityQueue}}
to maintain the timer structure base on the heap of each key group, and we never call `poll()`
on it.

> Potential null reference in KeyGroupPartitionedPriorityQueue#poll()
> -------------------------------------------------------------------
>
>                 Key: FLINK-9736
>                 URL: https://issues.apache.org/jira/browse/FLINK-9736
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: vinoyang
>            Priority: Minor
>
> {code}
>     final PQ headList = heapOfkeyGroupedHeaps.peek();
>     final T head = headList.poll();
> {code}
> {{peek}} call may return null.
> The return value should be checked before de-referencing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message