flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9784) Inconsistent use of 'static' in AsyncIOExample.java
Date Thu, 12 Jul 2018 11:44:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541507#comment-16541507

ASF GitHub Bot commented on FLINK-9784:

Github user asfgit closed the pull request at:


> Inconsistent use of 'static' in AsyncIOExample.java
> ---------------------------------------------------
>                 Key: FLINK-9784
>                 URL: https://issues.apache.org/jira/browse/FLINK-9784
>             Project: Flink
>          Issue Type: Bug
>          Components: Examples
>    Affects Versions: 1.5.0, 1.4.2
>            Reporter: Alexei Nekrassov
>            Assignee: Alexei Nekrassov
>            Priority: Minor
>              Labels: pull-request-available
> In SampleAsyncFunction having _executorService_ and _random_ as static, but _counter_
as instance-specific will not work when someone creates a second instance of SampleAsyncFunction.
In second SampleAsyncFunction the _counter_ will be 0 and we will re-intialize static _executorService_
and _random_, thus interfering with the first SampleAsyncFunction object.
> To fix this example and make it clearer, make _executorService_ and _random_ instance-specific.
That will make _counter_ redundant; also synchronization on class will no longer be needed.

This message was sent by Atlassian JIRA

View raw message