flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9785) Add remote addresses to LocalTransportException instances
Date Tue, 10 Jul 2018 08:12:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538233#comment-16538233
] 

ASF GitHub Bot commented on FLINK-9785:
---------------------------------------

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/6291

    [FLINK-9785][network] add remote address information to LocalTransportException instances

    ## What is the purpose of the change
    
    In contrast to the messages inside `RemoteTransportException`s, `LocalTransportException`
instances did not contain information about the remote end which complicated debugging and
correlating different log files.
    
    ## Brief change log
    
    - add remote address information to `LocalTransportException` instantiations
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): **no**
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **no**
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: **no**
      - The S3 file system connector: **no**
    
    ## Documentation
    
      - Does this pull request introduce a new feature? **no**
      - If yes, how is the feature documented? **not applicable**


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-9785

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6291.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6291
    
----
commit ada95a5eec12e07981cbc99f5530d3f0775b1daa
Author: Nico Kruber <nico@...>
Date:   2018-07-09T14:49:15Z

    [FLINK-9785][network] add remote address information to LocalTransportException instances

----


> Add remote addresses to LocalTransportException instances
> ---------------------------------------------------------
>
>                 Key: FLINK-9785
>                 URL: https://issues.apache.org/jira/browse/FLINK-9785
>             Project: Flink
>          Issue Type: Improvement
>          Components: Network
>    Affects Versions: 1.5.0, 1.4.2
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> {{LocalTransportException}} instantiations do not always add the remote address into
the exception message. Having this will ease debugging and make correlating different log
files much easier.
> There always is an address associated with these exceptions but it does not seem like
this is used anywhere for now and in that case it is also the local address (looks like its
intended to be the error source's address).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message