flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9785) Add remote addresses to LocalTransportException instances
Date Tue, 10 Jul 2018 11:17:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538414#comment-16538414
] 

ASF GitHub Bot commented on FLINK-9785:
---------------------------------------

Github user yanghua commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6291#discussion_r201303678
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandler.java
---
    @@ -167,7 +167,8 @@ public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause)
throws E
     				tex = new RemoteTransportException("Lost connection to task manager '" + remoteAddr
+ "'. " +
     					"This indicates that the remote task manager was lost.", remoteAddr, cause);
     			} else {
    -				tex = new LocalTransportException(cause.getMessage(), ctx.channel().localAddress(),
cause);
    +				final SocketAddress localAddr = ctx.channel().localAddress();
    +				tex = new LocalTransportException(cause.getMessage() + " (connection to '" + remoteAddr
+ "')", localAddr, cause);
    --- End diff --
    
    using `String.format` here looks better to me


> Add remote addresses to LocalTransportException instances
> ---------------------------------------------------------
>
>                 Key: FLINK-9785
>                 URL: https://issues.apache.org/jira/browse/FLINK-9785
>             Project: Flink
>          Issue Type: Improvement
>          Components: Network
>    Affects Versions: 1.5.0, 1.4.2
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> {{LocalTransportException}} instantiations do not always add the remote address into
the exception message. Having this will ease debugging and make correlating different log
files much easier.
> There always is an address associated with these exceptions but it does not seem like
this is used anywhere for now and in that case it is also the local address (looks like its
intended to be the error source's address).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message