flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9799) Generalize/unify state meta info
Date Thu, 12 Jul 2018 13:38:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541658#comment-16541658
] 

ASF GitHub Bot commented on FLINK-9799:
---------------------------------------

Github user azagrebin commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6308#discussion_r202035286
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/SerializationProxiesTest.java
---
    @@ -126,11 +131,11 @@ public void testKeyedBackendSerializationProxyRoundtripWithSerializerSerializati
     		Assert.assertTrue(serializationProxy.getKeySerializer() instanceof UnloadableDummyTypeSerializer);
     		Assert.assertEquals(keySerializer.snapshotConfiguration(), serializationProxy.getKeySerializerConfigSnapshot());
     
    -		for (RegisteredKeyedBackendStateMetaInfo.Snapshot<?, ?> meta : serializationProxy.getStateMetaInfoSnapshots())
{
    -			Assert.assertTrue(meta.getNamespaceSerializer() instanceof UnloadableDummyTypeSerializer);
    -			Assert.assertTrue(meta.getStateSerializer() instanceof UnloadableDummyTypeSerializer);
    -			Assert.assertEquals(namespaceSerializer.snapshotConfiguration(), meta.getNamespaceSerializerConfigSnapshot());
    -			Assert.assertEquals(stateSerializer.snapshotConfiguration(), meta.getStateSerializerConfigSnapshot());
    +		for (StateMetaInfoSnapshot meta : serializationProxy.getStateMetaInfoSnapshots()) {
    --- End diff --
    
    Change like
    `RegisteredKeyedBackendStateMetaInfo.Snapshot<?, ?> meta -> RegisteredKeyedBackendStateMetaInfo(StateMetaInfoSnapshot)`
    and then using original assertions might be more complete version of test.
    Also for other meta wrappers in further tests


> Generalize/unify state meta info
> --------------------------------
>
>                 Key: FLINK-9799
>                 URL: https://issues.apache.org/jira/browse/FLINK-9799
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.5.0
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>            Priority: Major
>              Labels: pull-request-available
>
> Flink currently has a couple of classes that describe the meta data of state (e.g. for
keyed state, operator state, broadcast state, ...) and they typically come with their own
serialization proxy and backwards compatibility story. However, the differences between those
meta data classes are very small, like different option flags and a different set of serializers.
Before introducing yet another meta data for timers, we should unify them in a general state
meta data class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message