[ https://issues.apache.org/jira/browse/FLINK-9807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541497#comment-16541497
]
ASF GitHub Bot commented on FLINK-9807:
---------------------------------------
Github user klion26 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6305#discussion_r202001215
--- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/LocalRecoveryITCase.java
---
@@ -25,35 +25,46 @@
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TestName;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collection;
-import static org.apache.flink.test.checkpointing.AbstractEventTimeWindowCheckpointingITCase.StateBackendEnum;
+import static org.apache.flink.test.checkpointing.EventTimeWindowCheckpointingITCase.StateBackendEnum;
+import static org.apache.flink.test.checkpointing.EventTimeWindowCheckpointingITCase.StateBackendEnum.FILE_ASYNC;
+import static org.apache.flink.test.checkpointing.EventTimeWindowCheckpointingITCase.StateBackendEnum.ROCKSDB_FULLY_ASYNC;
+import static org.apache.flink.test.checkpointing.EventTimeWindowCheckpointingITCase.StateBackendEnum.ROCKSDB_INCREMENTAL_ZK;
/**
- * This test delegates to instances of {@link AbstractEventTimeWindowCheckpointingITCase}
that have been reconfigured
+ * This test delegates to instances of {@link EventTimeWindowCheckpointingITCase} that
have been reconfigured
* to use local recovery.
*
- * <p>TODO: This class must be refactored to properly extend {@link AbstractEventTimeWindowCheckpointingITCase}.
+ * <p>TODO: This class must be refactored to properly extend {@link EventTimeWindowCheckpointingITCase}.
--- End diff --
I this the TODO still needed, because this PR is not for it
> Improve EventTimeWindowCheckpointITCase&LocalRecoveryITCase with parameterized
> ------------------------------------------------------------------------------
>
> Key: FLINK-9807
> URL: https://issues.apache.org/jira/browse/FLINK-9807
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.5.0
> Reporter: Congxian Qiu
> Priority: Major
> Labels: pull-request-available
>
> Now, the `AbastractEventTimeWIndowCheckpointITCase` and `AbstractLocalRecoveryITCase`
need to re-implement for every backend, we can improve this by using JUnit parameterized
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
|