flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9849) Upgrade hbase version to 2.0.1 for hbase connector
Date Wed, 18 Jul 2018 16:19:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548027#comment-16548027
] 

ASF GitHub Bot commented on FLINK-9849:
---------------------------------------

Github user yanghua commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6365#discussion_r203438579
  
    --- Diff: flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
    @@ -81,7 +85,9 @@ private HTable createTable() {
     		org.apache.hadoop.conf.Configuration hConf = HBaseConfiguration.create();
     
     		try {
    -			return new HTable(hConf, getTableName());
    +			Connection connection = ConnectionFactory.createConnection(hConf);
    +			Table table = connection.getTable(TableName.valueOf(getTableName()));
    +			return (HTable) table;
    --- End diff --
    
    I think we should release the connection when happens exception


> Upgrade hbase version to 2.0.1 for hbase connector
> --------------------------------------------------
>
>                 Key: FLINK-9849
>                 URL: https://issues.apache.org/jira/browse/FLINK-9849
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: zhangminglei
>            Priority: Major
>              Labels: pull-request-available
>
> Currently hbase 1.4.3 is used for hbase connector.
> We should upgrade to 2.0.1 which was recently released.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message