flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9885) End-to-end test: Elasticsearch 6.x connector
Date Mon, 30 Jul 2018 08:25:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561625#comment-16561625
] 

ASF GitHub Bot commented on FLINK-9885:
---------------------------------------

twalthr commented on a change in pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch
6.x
URL: https://github.com/apache/flink/pull/6391#discussion_r206040386
 
 

 ##########
 File path: flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch6/ElasticsearchSink.java
 ##########
 @@ -62,62 +64,51 @@
 	/**
 	 * Creates a new {@code ElasticsearchSink} that connects to the cluster using a {@link RestHighLevelClient}.
 	 *
-	 * <p>This constructor uses the default configurations of the {@link RestHighLevelClient}.
For custom
-	 * configuration, please use the {@link #ElasticsearchSink(Map, List, ElasticsearchSinkFunction,
RestClientFactory)}
-	 * constructor.
-	 *
-	 * @param userConfig user configuration to configure bulk flushing behaviour.
-	 * @param elasticsearchSinkFunction This is used to generate multiple {@link ActionRequest}
from the incoming element
-	 * @param httpHosts The list of {@link HttpHost} to which the {@link RestHighLevelClient}
connects to.
-	 */
-	public ElasticsearchSink(Map<String, String> userConfig, List<HttpHost> httpHosts,
ElasticsearchSinkFunction<T> elasticsearchSinkFunction) {
-
-		this(
-			userConfig,
-			httpHosts,
-			elasticsearchSinkFunction,
-			restClientBuilder -> {} // a no-op rest client factory, that uses the default configurations
-		);
-	}
-
-	/**
-	 * Creates a new {@code ElasticsearchSink} that connects to the cluster using a {@link RestHighLevelClient}.
-	 *
-	 * @param userConfig user configuration to configure bulk flushing behaviour.
+	 * @param bulkRequestsConfig user configuration to configure bulk flushing behaviour.
 	 * @param httpHosts The list of {@link HttpHost} to which the {@link RestHighLevelClient}
connects to.
 	 * @param elasticsearchSinkFunction This is used to generate multiple {@link ActionRequest}
from the incoming element.
+	 * @param failureHandler This is used to handle failed {@link ActionRequest}.
 
 Review comment:
   Remove the JavaDoc for the private constructor and add them to the builder instead? The
builder doc is the important one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> End-to-end test: Elasticsearch 6.x connector
> --------------------------------------------
>
>                 Key: FLINK-9885
>                 URL: https://issues.apache.org/jira/browse/FLINK-9885
>             Project: Flink
>          Issue Type: Sub-task
>          Components: ElasticSearch Connector, Tests
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Tzu-Li (Gordon) Tai
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> We have decided to try and merge the pending Elasticsearch 6.x PRs. This should also
come with an end-to-end test that covers this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message